Explicitly support vm.dirty_(bytes|ratio) and vm.dirty_background_(bytes|ratio) #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
zacikpa
force-pushed
the
dirty-bytes
branch
from
2545607 to
4c724c2
Compare
Thank you! Planning to take a look today, tomorrow at the latest. |
jmencak
reviewed
Sep 18, 2024
There was a problem hiding this comment.
Thank you for the PR, Pavol. I've tested the code and it resolves https://issues.redhat.com/browse/RHEL-58820. I've also checked the changes in TuneD profiles. They seem fine. Also had a quick look at the code and apart from a minor nit with the style (which is a matter of opinion anyway) it looks fine to me.
zacikpa
force-pushed
the
dirty-bytes
branch
from
4c724c2 to
c603d8c
Compare
|
Thank you for the changes. I believe the whole PR is cleaner this way. I've also retested the scenario in RHEL-58820. |
|
@zacikpa please fix the conflict. |
And for dirty_background_(bytes|ratio). These parameters interact with each other; it is therefore not sufficient to configure them via the sysctl plugin. For more details, see https://docs.kernel.org/admin-guide/sysctl/vm.html#dirty-bytes. Resolves: RHEL-58820
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The options interact within these two pairs: when
dirty_bytesis set,dirty_ratiois automatically set to 0 and vice versa. Rollback thus does not work out of the box when setting these options via the sysctl plugin.This PR adds explicit support for the options into the VM plugin: the new custom commands check whether the value set in the profile is permitted and the rollback is adjusted: the option that was not 0 before the profile switch is reverted.
@jmencak, feel free to test this.